Remove old schema v1 syntax#1004
Draft
simolus3 wants to merge 5 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 3fe3cd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Tableconstructor supports two syntax variants:Since the v1 variant is deprecated and a comment explains that it'll be removed in the next major release, now is the time for that. This PR:
TableV2Options), replacing them with plain names (TableOptions).Tableconstructor.The ability to construct a table from an array of columns is still useful, however:
So, this adds
ResolvedTableas an advanced class representing columns the old way. This kind of weakens the idea of removing v1 variants, but I think being explicit about the way tables are constructed (instead of allowing both styles on the same constructor) is a decent simplification already.AI use: I used Claude Code to help migrate a helper types and demos.